Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore. updateFields compatibility with php 7 and 8 #51

Closed
wants to merge 2 commits into from

Conversation

pangolp
Copy link

@pangolp pangolp commented Aug 30, 2024

I need someone to test this, because I don't know if it will work. I don't use this product at the moment, so I don't have a local version to test.

@pangolp
Copy link
Author

pangolp commented Aug 30, 2024

Perhaps the version check should be done outside the foreach, because it will check the version several times and checking it once would be more than enough.

@pangolp
Copy link
Author

pangolp commented Aug 31, 2024

@Sarjuuk Could you give me some feedback on this change? Thanks.

@Sarjuuk
Copy link

Sarjuuk commented Aug 31, 2024

ffs merge, you are 250+ commits behind!
Sarjuuk@d16b08b fixed that

Or just always cast to float. Why would you differentiate between versions?

@pangolp
Copy link
Author

pangolp commented Aug 31, 2024

ffs merge, you are 250+ commits behind!
Sarjuuk@d16b08b fixed that

Or just always cast to float. Why would you differentiate between versions?

It was an issue they opened. The truth is not. Just look for the solution and I shared it. The repository should then be updated first or directly archived and worked with the dream.

@Helias
Copy link
Member

Helias commented Aug 31, 2024

ffs merge, you are 250+ commits behind! [Sarjuuk/aowow@d16b08b]

I know 😢 #47

I will do it when I'll have more time.

About this PR, I think it's better to align directly with Sarjuuk/aowow instead of do similar changes that will cause more merging conflicts

@pangolp
Copy link
Author

pangolp commented Sep 1, 2024

I think we should close this issue then and update the repository.

@pangolp pangolp closed this Sep 1, 2024
@pangolp pangolp deleted the updateFields branch September 1, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument #1 ($num) must be of type float, string given
3 participants